-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-stag] Do not check for defaultCredit #29915
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
In regards to this comment: I do not think we need to pass a parameter from the back end, as it would be redundant. As long as the user has an OPEN PBA or debit card then this method should return true because something will be linked to the wallet. |
Deploying with Cloudflare Pages
|
@joelbettner can you make the update Maria requested? |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Cole asked me if i could approve and merge this so it goes out the door sooner. |
CP-ing to staging as per this comment |
Do not check for defaultCredit (cherry picked from commit fda38e2)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 1.3.87-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀
|
@coleaeason @MariaHCD will you please review?
The
hasExpensifyPaymentMethod
method is used when going through KYC flow to determine if a user can move forward with a legitimate account to link to their wallet. It is also used to determine if a user can be shown the button to transfer funds out of their wallet if they have a legitimate linked account for doing so.We were relying on the
defaultCredit
column of a bank account to determine this, but we should not be doing that any longer.This PR updates the
hasExpensifyPaymentMethod
method to returntrue
if the user has any PBA that is OPEN.Fixed Issues
$ #29320
Tests
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop